-
Notifications
You must be signed in to change notification settings - Fork 11
feat(flagd): improve in-process evaluation mode, optimize dependencies #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Eren Atas <[email protected]>
Summary of ChangesHello @erenatas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the in-process evaluation mode of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is an excellent pull request that brings a host of significant improvements to the flagd crate. The migration from anyhow to thiserror for typed error handling, dependency optimizations, and the introduction of notify for efficient file watching are all major wins for robustness and performance. The addition of features like graceful shutdown, Unix socket support, and selective cache invalidation further enhance the library's capabilities. The fix for struct serialization in the targeting context is a crucial correctness improvement. The code is well-structured, and the addition of documentation and extensive unit tests is commendable. I have one suggestion to improve the file watcher's reliability.
This PR
is mostly improvements on gRPC streaming performance, file watching, and code quality
gRPC Streaming Performance
Reduces latency on reconnects and improves connection reliability:
File Watching & Storage
Configuration Alignment with Go Provider
FLAGD_KEEP_ALIVE_TIME_MSenv var)Dependency Optimization
Code Quality
Examples
Breaking Changes (Behavioral)
evaluates fresh each time. Users can re-enable with
cache_settings: Some(...)it wascache_settings: Some(CacheSettings::default()),.Follow-up Tasks
I plan to follow up with an optional opentelemetry feature for metrics.
tracingcrate (for logging) already subscribes to otel for logs automatically