VirtualImagePlus: Retain B&C settings for each slice #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures relate to the 16bit tests, requires further investigation |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/19 |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/21 |
|
Following on from https://forum.image.sc/t/bio-formats-support/101109, it's unclear if there will be capacity to move this PR forward. We've removed it from 8.0.0 for the moment. If anyone is interested in getting involved, please let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to a previous PR https://github.com/ome/bioformats/pull/3850/files and is an attempt to address the issues raised in https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/10
The fix here reapplies the table settings for each slice using the same approach as the ContrastAdjuster. This may be overkill and there may be a simpler solution to ensure that the settings are applied for each slice.