-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lidar Safety Node Advanced #62
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Function docstring comments
- change "callback" to more specific - e.x. "lidar_cb"
- Not running anything . . .
- In run loop, check for "rospy.is_shutdown"
- Also, throw in a section that waits until it gets lidar data to run main loop. Put in run function.
- Last command in "if name == "main" should be calling run function.
- Set up a rospy.Rate()
- For var name and comments, reference base_link coordinate system
- Draw and save quick diagram labeling geometries
You're super cool though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add downward-facing lidar and run some tests.
… from left to right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Output twist messages that conform to the new state controller
- Register node as safety behavior by following instructions on wiki
- Implement some way to run with or w/o groundlidar
- Test with Amy's simulation
I changed the code and made it nicer.