Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to ddtrace.tracer from a non deprecated location #198

Closed
wants to merge 1 commit into from
+3 −3
Closed

Refer to ddtrace.tracer from a non deprecated location #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ classifiers = [
]
license = {text = "MIT"}
dependencies = [
"ddtrace>=1.9.0,<2.20.0",
"ddtrace>=2.20.0,<2.21.0",
"duckdb>=0.9.0",
"django>=4.0",
"openpyxl>=3.1.0",
4 changes: 2 additions & 2 deletions xocto/tracing.py
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from __future__ import annotations

import ddtrace
import ddtrace.trace


tracer = ddtrace.tracer
tracer = ddtrace.trace.tracer
Copy link
Contributor

@Peter554 Peter554 Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this.

Is this going to work with Kraken? Kraken is using ddtrace version 2.14.4 and in 2.14.4 this code will raise AttributeError: module 'ddtrace.trace' has no attribute 'tracer'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime #199

wrap = tracer.wrap