Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to ddtrace.tracer from a non deprecated location #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

delfick
Copy link
Contributor

@delfick delfick commented Jan 31, 2025

Prior to this the recent upgrade of ddtrace deprecated accessing tracer from ddtrace.

It is instead exported from ddtrace.trace now

Prior to this the recent upgrade of ddtrace deprecated accessing tracer
from ddtrace.

It is instead exported from ddtrace.trace now


tracer = ddtrace.tracer
tracer = ddtrace.trace.tracer
Copy link
Contributor

@Peter554 Peter554 Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this.

Is this going to work with Kraken? Kraken is using ddtrace version 2.14.4 and in 2.14.4 this code will raise AttributeError: module 'ddtrace.trace' has no attribute 'tracer'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants