-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more attributes of vacuum #14
base: master
Are you sure you want to change the base?
Add more attributes of vacuum #14
Conversation
Hi @nqkdev , could you please look at this PR of @KrzysztofHajdamowicz ? I would really love to use this custom component with all the added functionality. Would also be great to have it added to HACS too. |
For those interested I forked the repo and merged this and the pep8 PRs |
Great! In the meanwhile I'm using KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym since it was the most up to date and gives me extra functionality and the bug resolved. How is yours compared to this one? |
KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym@master...nelsongraca:master |
Thanks for the clarification. Didn't know you could compare that simple :) |
@KrzysztofHajdamowicz missed that you had an updated repo, in that case mine is useless, BTW is this the same as the viomi.vacuum.v8? I got that model and some attributes seem wrong. |
Dunno :( I've just merged changes from existing forks of upstream repo, I own STYTJ02YM and it is hard for me to debug hardware I did not have in my hands :( |
Nevermind found the SKU: SKV4109GL not the same, time to try it out. |
This PR contains improvements created by @kovbalazs89, @pierosavi and @bashau in forks of this repository and merges them into one piece, allowing upstream repository to be in sync with downstream ones.
To be merged after #13