Skip to content

refactor(worker): simplify step halt return condition #9947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChmaraX merged 2 commits into from
Jan 30, 2026
+1 −5
Merged

refactor(worker): simplify step halt return condition #9947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c2405b
refactor(worker): eliminate duplicate return logic in shouldHaltOnSte…
cursoragent Jan 30, 2026
e7ed9b0
refactor(worker): add null check for job.type in condition
cursoragent Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions apps/worker/src/app/shared/utils/should-halt-on-step-failure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,10 @@ import { isActionStepType } from '@novu/application-generic';
import { JobEntity } from '@novu/dal';

export const shouldHaltOnStepFailure = (job: JobEntity): boolean => {
if (!job.type) {
return job.step.shouldStopOnFail === true;
}

/*
* Action steps always stop on failure across all versions (v1 & v2)
*/
if (isActionStepType(job.type)) {
if (job.type && isActionStepType(job.type)) {
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says this change improves robustness by only calling isActionStepType when job.type is present, but the previous implementation already short-circuited on !job.type. If there’s no intended behavior change here, consider updating the PR description to reflect that this is a refactor/simplification only (or add a note if a subtle behavior/typing issue was being addressed).

Copilot uses AI. Check for mistakes.
return true;
}

Expand Down
Loading