refactor(worker): simplify step halt return condition

[ChmaraX]

This pull request makes a small change to the should-halt-on-step-failure.ts utility function, improving the handling of jobs that may not have a defined type property. The update ensures that the function only checks for action step types when job.type is present, making the logic more robust.

This pull request contains changes generated by a Cursor Cloud Agent

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[netlify]

✅ Deploy Preview for dashboard-v2-novu-staging canceled.

Name	Link
🔨 Latest commit	e7ed9b0
🔍 Latest deploy log	https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/697ccd8fe22b840008e5c57b

[coderabbitai]

Warning

Rate limit exceeded

@ChmaraX has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 47 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: refactor(worker): simplify step halt return condition

Requirements:

1. Follow the Conventional Commits specification
2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

[Copilot]

Pull request overview

Refactors shouldHaltOnStepFailure to simplify the halt decision logic by collapsing the job.type early-return into a single guarded condition.

Changes:

• Removes the explicit !job.type early return.
• Guards the isActionStepType check with job.type in a single conditional.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The PR description says this change improves robustness by only calling isActionStepType when job.type is present, but the previous implementation already short-circuited on !job.type. If there’s no intended behavior change here, consider updating the PR description to reflect that this is a refactor/simplification only (or add a note if a subtle behavior/typing issue was being addressed).