Bug Fix BZ 2242414 | Add Flag app-namespace To Command obc regenerate
#1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add flag app-namespace to command obc regenerate 2. rename ob name to ob-%s-%s instead of obs-%s-%s 3. fix a couple of typos Signed-off-by: shirady <[email protected]>
2 tasks
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
app-namespaceto commandobc regenerate(it is used in the code, but not in the usage).ob.Nametoob-%s-%sinstead ofobs-%s-%s.Issues: Fixed BZ 2242414
Note: for the complete fix also needed PR #1231.
Testing Instructions:
After we have an image of noobaa-cli with those changes and we installed noobaa (tested on the cluster-bot):
oc new-project craig-ns1noobaa obc create craig-test-obc2 --app-namespace craig-ns1.noobaa obc regenerate craig-test-obc2 --app-namespace craig-ns1.