Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 5.13] Bug Fix BZ 2242414 #1270

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

dannyzaken
Copy link
Member

Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking, till we bump the version
#1272

1. add flag app-namespace to command obc regenerate
2. rename ob name to ob-%s-%s instead of obs-%s-%s
3. fix a couple of typos

Signed-off-by: shirady <[email protected]>
(cherry picked from commit 1338f0c)
Signed-off-by: Danny Zaken <[email protected]>
…bc regenerate)

Signed-off-by: shirady <[email protected]>
(cherry picked from commit 560a17c)
Signed-off-by: Danny Zaken <[email protected]>
@dannyzaken dannyzaken merged commit 748d801 into noobaa:5.13 Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants