-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added format configuration defaults for noir #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
changed the title
Added format configuration defaults for noir
chore: Added format configuration defaults for noir
Dec 11, 2023
Can you resolve the merge conflicts with the package-lock.json? |
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
TomAFrench
force-pushed
the
gj/format-on-save-default
branch
from
December 11, 2023 20:29
a5dbe08
to
df68b35
Compare
Does it not format by default already? My vscode autoformats noir source code. |
kobyhallx
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm, ty! 💯
Savio-Sou
changed the title
chore: Added format configuration defaults for noir
feat: Added format configuration defaults for noir
Dec 13, 2023
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added configuration defaults for noir code formatting using
vscode-noir
.Problem*
Resolves #54
VSCode extension was not formatting
.nr
files by default even thought the LSP supported the feature and advertises itself asdocumentFormattingProvider: true
. This could be manually fixed with settings:Summary*
Simple
package.json
changes according to the extension contributions documentation. It must be noted that it is now not recommended to include the formatting capabilities of an extension as a setting for the extension itself, as it can cause a bunch of problems if multiple ones do the same.As such, this change uses the recommended method of providing formatting capabilities for noir (and only for noir!) as a language-specific override of the editor's default setting.
PR Checklist*
cargo fmt
on default settings.BEGIN_COMMIT_OVERRIDE
feat: Added format configuration defaults for noir (#55)
END_COMMIT_OVERRIDE