Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove format on save override #65

Merged
merged 1 commit into from
Jan 26, 2024
Merged

chore: Remove format on save override #65

merged 1 commit into from
Jan 26, 2024

Conversation

Savio-Sou
Copy link
Contributor

Description

Problem*

#55 added the default configuration:

"editor.formatOnSave":  true

Useful when users prefer auto-formatting.

Troublesome when users do not, as it overrides VS Code's global editor.formatOnSave setting (i.e. users cannot disable auto-formatting on Noir, even when the Format on Save option in VS Code's settings is unchecked).

Summary*

Remove the override.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Savio-Sou Savio-Sou added the enhancement New feature or request label Jan 24, 2024
@kevaundray kevaundray merged commit e67abbf into master Jan 26, 2024
4 checks passed
@kevaundray kevaundray deleted the ss/remove-format-override branch January 26, 2024 15:26
TomAFrench added a commit that referenced this pull request Mar 4, 2024
@TomAFrench
Merge branch 'master' into kh-enable-code-lens-setting
83fad2b 
* master:
  feat(aztec): search for aztec-nargo on top of nargo bin (#67)
  feat: add `unchecked` keyword highlighting (#72)
  feat: add keyword highlighting for databus visibility keywords (#68)
  chore: Remove format on save override (#65)
  chore: Remove environment reference (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunkar Thunkar Awaiting requested review from Thunkar

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Savio-Sou @kevaundray