Skip to content

[v24.x][riscv] V8 backport to resolve compile failure #60989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sxa wants to merge 1 commit into
base: v24.x-staging
Choose a base branch
from
Open

[v24.x][riscv] V8 backport to resolve compile failure #60989

sxa wants to merge 1 commit into from
+40 −3

Conversation

@sxa
Copy link
Member

@sxa sxa commented Dec 8, 2025

Failure referenced in nodejs/build#4099 (comment) - the single line fix to
deps/v8/src/execution/riscv/simulator-riscv.h is enough to allow the cross-compiled build to pass but it seems cleaner to to pull the full commit across. If any reviewers disagree then I'm happy to cut this down to just the single line.

This will allow us to enable v24.x in the unofficial-builds repository.

@sxa sxa self-assigned this Dec 8, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Dec 8, 2025
@sxa sxa added request-ci Add this label to start a Jenkins CI on a PR. riscv64 Issues and PRs related to the riscv64 architecture. labels Dec 8, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20026379622

@sxa sxa mentioned this pull request Dec 8, 2025
Open
9 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70423/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70425/

@sxa sxa force-pushed the v24-riscv-v8-fix branch from 7f35cc3 to 8e38994 Compare December 8, 2025 12:58
@sxa sxa added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Dec 8, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20029272474

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6911/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6911/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6911/

@sxa sxa force-pushed the v24-riscv-v8-fix branch from 8e38994 to 8464545 Compare December 8, 2025 16:37
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70433/

@sxa sxa force-pushed the v24-riscv-v8-fix branch from 8464545 to 209b915 Compare December 8, 2025 16:48
@dstolfa @sxa
deps: V8: cherry-pick 1441665e0d87
0355396 
Original commit message:

    [riscv] Fix the RISC-V build.

    Due to recent changes, there were missing implementations of various
    methods needed in the simulator and Maglev. Additionally, a static_cast
    is needed in the assembler to silence a warning.

    Port commit dfc894cd22d86ce42830e3bfdf485d963f6396ad
    Port commit c33af9bd408eadd6b62571f862bcb5b763c98ad9

    Change-Id: Ie37a1cfa8225fc12f367ff62139cc7cd8fa967d0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6396542
    Reviewed-by: Victor Gomes <[email protected]>
    Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Reviewed-by: Yahan Lu (LuYahan) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#99706}

Refs: v8/v8@1441665
@sxa sxa force-pushed the v24-riscv-v8-fix branch from 209b915 to 0355396 Compare December 8, 2025 16:49
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70434/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6914/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6914/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6914/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70449/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70450/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70451/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70461/

@Renegade334 Renegade334 linked an issue Dec 9, 2025 that may be closed by this pull request
[RISCV] Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset. #60895
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70468/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70470/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

@sxa sxa

Labels

needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. riscv64 Issues and PRs related to the riscv64 architecture. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RISCV] Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset.

4 participants

@sxa @nodejs-github-bot @richardlau @dstolfa