Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automation #222

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Jul 11, 2023

Main changes

  • Replace credentials.json for a environmental variable MAILGUN_API_KEY
  • Added pipelines to manage changes in Mailgun
    • ci.yml to check that the changes are valid using --dry-run
    • cd.yml to apply the changes to Mailgun
  • Added support for nvm and normalized node.js engine version to 18
  • Docs updated

Note

I will include the MAILGUN_API_KEY secret in the repository if we agree on it, as the pipelines will require it

Changelog

@UlisesGascon UlisesGascon self-assigned this Jul 11, 2023
@UlisesGascon UlisesGascon marked this pull request as ready for review July 11, 2023 06:27
@mhdawson
Copy link
Member

@nodejs/build-infra I'm asking similar questions in a few PRs related to adding tokens for access to sensitive build assets for GitHub workflows. It may just be that we should trust GitHub and we've already added equivalent tokens but I'd like to get input from other build team members on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants