Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge & Deploy process #255

Open
legendecas opened this issue Jul 25, 2024 · 1 comment
Open

Merge & Deploy process #255

legendecas opened this issue Jul 25, 2024 · 1 comment

Comments

@legendecas
Copy link
Member

legendecas commented Jul 25, 2024 •
edited
Loading

I think I have accidentally merged PRs in this repo that were expected to be merged by @nodejs/build-infra team (https://github.com/nodejs/email?tab=readme-ov-file#responsibility), due to the inciting big green "merge" button on the PR once been approved (sorry!!).

Can we can add code owner requirement on merging PRs, or automate the deploy process?
@UlisesGascon
Copy link
Member

Until we feel comfortable with the automation (proposal in #222) I agree that code owner requirement is a great idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@UlisesGascon @legendecas