Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: 64bit support #156

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
name: Build

on:
push:
branches:
- "*"
pull_request:
branches:
- "*"
on: [push, pull_request]

jobs:
build-linux-i386:
Expand Down Expand Up @@ -47,6 +41,17 @@ jobs:
./waf.bat configure -T debug
./waf.bat build

build-windows-amd64:
runs-on: windows-2019

steps:
- uses: actions/checkout@v2
- name: Build windows-i386
Copy link
Contributor

@LegendaryGuard LegendaryGuard Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful! The name is wrong, it isn't i386, it's amd64. Btw, good luck! 👍

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shit happens

run: |
git submodule init && git submodule update
./waf.bat configure -T debug -8
./waf.bat build

build-dedicated-windows-i386:
runs-on: windows-2019

Expand All @@ -58,6 +63,17 @@ jobs:
./waf.bat configure -T debug -d
./waf.bat build

build-dedicated-windows-amd64:
runs-on: windows-2019

steps:
- uses: actions/checkout@v2
- name: Build dedicated windows-amd64
run: |
git submodule init && git submodule update
./waf.bat configure -T debug -d -8
./waf.bat build

build-dedicated-linux-i386:
runs-on: ubuntu-18.04

Expand Down
22 changes: 15 additions & 7 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
name: Tests

on:
push:
branches:
- "*"
pull_request:
branches:
- "*"
on: [push, pull_request]

jobs:
tests-linux-i386:
Expand Down Expand Up @@ -40,3 +34,17 @@ jobs:
cd out
$env:Path = "bin";
./unittest.exe

tests-windows-amd64:
runs-on: windows-2019

steps:
- uses: actions/checkout@v2
- name: Run tests windows-amd64
run: |
git submodule init && git submodule update
./waf.bat configure -T release --tests --prefix=out/ -8
./waf.bat install
cd out
$env:Path = "bin";
./unittest.exe
2 changes: 1 addition & 1 deletion dedicated/sys_ded.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ bool CDedicatedSteamApplication::Create( )
//-----------------------------------------------------------------------------
int main(int argc, char **argv)
{
#ifndef POSIX
#if !defined( POSIX ) && !defined( PLATFORM_64BITS )
_asm
{
fninit
Expand Down
4 changes: 2 additions & 2 deletions game/client/client_thinklist.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ void CClientThinkList::RemoveThinkable( ClientThinkHandle_t hThink )
{
pThink->SetThinkHandle( INVALID_THINK_HANDLE );
}
m_ThinkEntries.Remove( (unsigned long)hThink );
m_ThinkEntries.Remove( (uintp)hThink );
}


Expand Down Expand Up @@ -304,7 +304,7 @@ void CClientThinkList::PerformThinkFunctions()
if ( hThink != INVALID_THINK_HANDLE )
{
// This can happen if the same think handle was removed twice
if ( !m_ThinkEntries.IsInList( (unsigned long)hThink ) )
if ( !m_ThinkEntries.IsInList( (uintp)hThink ) )
continue;

// NOTE: This is necessary for the case where the client entity handle
Expand Down
2 changes: 1 addition & 1 deletion game/client/client_thinklist.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ inline ClientThinkHandle_t CClientThinkList::GetInvalidThinkHandle()

inline CClientThinkList::ThinkEntry_t* CClientThinkList::GetThinkEntry( ClientThinkHandle_t hThink )
{
return &m_ThinkEntries[ (unsigned long)hThink ];
return &m_ThinkEntries[ (uintp)hThink ];
}


Expand Down
2 changes: 1 addition & 1 deletion game/client/clientleafsystem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1337,7 +1337,7 @@ void CClientLeafSystem::ComputeTranslucentRenderLeaf( int count, const LeafIndex

static CUtlVector<RenderableInfo_t *> orderedList; // @MULTICORE (toml 8/30/2006): will need to make non-static if thread this function
static CUtlVector<IClientRenderable *> renderablesToUpdate;
int leaf = 0;
intp leaf = 0;
for ( i = 0; i < count; ++i )
{
leaf = pLeafList[i];
Expand Down
2 changes: 1 addition & 1 deletion public/tier1/memhelpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace memutils
}

template<typename T>
inline void set( T *dest, T value, size_t n )
inline void set( T *dest, const T &value, size_t n )
{
do
{
Expand Down
3 changes: 2 additions & 1 deletion wscript
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,8 @@ def configure(conf):
'/Zc:forScope',
'/Zc:wchar_t',
'/GR',
'/TP'
'/TP',
'/EHsc'
]

if conf.options.BUILD_TYPE == 'debug':
Expand Down