Undefined external #2
Conversation
Adding test cases to zzz-rsyslog.sh Adding the undefined field related env vars to rsyslog/README.md. Adding multi-container support to the rsyslog logs utility. Adding undefined test cases 6 & 7 to test/viaq-data-model.sh.
The `if` command itself will return true or false - no need to enclose in `$( ... )`
The undefined_field mmexternal program should be quiet if undefined_debug is not set
@@ -346,11 +346,11 @@ cat > $cfgdir/66-debug.conf << EOF .... -set \$!undefined12 = "True"; +set \$!undefined12 = True; .... -set \$!undefined2!undefined23 = "False"; +set \$!undefined2!undefined23 = False;
remove the check for noaction. There will always be an "action" by this command - it will always strip empty fields. After recursing through nested maps and arrays, check to see if they are empty after recursing, and remove them if they are now empty.
If we recursively cleared out a map or an array, only keep the field if it is in keep_empty. Only count the field against the max number of undefined fields if we actually used it in the result. There is no `arraymap` - it's just an `array`
test improvements - added start_rsyslog, stop_rsyslog to make it easier and safer to change and restart rsyslog for testing make rsyslog read from tail to speed up testing write impstats.json for testing
nhosoi
force-pushed
the
undefined_external
branch
from
04e09fa to
c444db9
Compare
|
@richm, shall I also add some test cases to the unit test if there are some cases you haven't started? |
Yes, please. There is currently no test for |
I go for |
nhosoi
force-pushed
the
undefined_external
branch
5 times, most recently
from
0fd38a5 to
ca4c8c0
Compare
I'll submit a PR against your branch - we'll see how hard it is to merge