-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide social sync option if social sync is not available #2913
base: main
Are you sure you want to change the base?
Conversation
This mod hides `Update avatars from social media (refreshed once per week)` checkbox from contacts settings if syncing avatars is disabled by admin or no internet connection is avalable. Author-Change-Id: IB#1125033 Related: nextcloud#1594 Signed-off-by: Pawel Boguslawski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, thank you for this improvement!
not sure if it is good practice to add your copyright to all the files where you have added a word.
@@ -4,6 +4,7 @@ | |||
|
|||
/** | |||
* @copyright 2017 Georg Ehrke <[email protected]> | |||
* @copyright Copyright (c) 2022 Informatyka Boguslawski sp. z o.o. sp.k., http://www.ib.pl/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
triple copyright and no https? 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
+ Coverage 5.17% 8.33% +3.15%
==========================================
Files 110 87 -23
Lines 1874 1164 -710
Branches 238 239 +1
==========================================
Hits 97 97
+ Misses 1662 952 -710
Partials 115 115 ☔ View full report in Codecov by Sentry. |
CI isn't happy :) |
@pboguslawski ping :) can you fix the CI issues please? you can lint with and the SocialApiServiceTest fixing. |
Fixes: 8a84821 Related: nextcloud#2913 (comment) Author-Change-Id: IB#1125033 Signed-off-by: Pawel Boguslawski <[email protected]>
Fixed in 3aaf6ef.
Not sure why this test fails. Maybe |
I'm trying to update the branch to get CI running. Unfortunately the settingssection component was remvoed with #3032. |
I succeeded with the update but @pboguslawski's branch doesn't allow me to push. @pboguslawski could you please update the branch yourself? You have to move the settingsection changes to src/components/AppNavigation/ContactsSettings.vue |
Fixed in 2b3d45e. |
@pboguslawski friendly ping to update the copyright section
|
Co-authored-by: Anna <[email protected]> Signed-off-by: Paweł Bogusławski <[email protected]>
Restored copyright note that was removed unintentionally (8f9d697). |
This PR should not modify other Copyright notices. Signed-off-by: Paweł Bogusławski <[email protected]>
After further investigation, removed this copyright in b741dd6 because it should not be modified in this PR (removal was effect of main merge and there is no such copyright in |
This mod hides
Update avatars from social media (refreshed once per week)
checkbox from contacts settings if syncing avatars is disabled by admin
or no internet connection is avalable.
Author-Change-Id: IB#1125033
Related: #1594
Signed-off-by: Pawel Boguslawski [email protected]