Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Allow updating avatars from social media" when internet access is disabled #2914

Open
pboguslawski opened this issue Sep 5, 2022 · 2 comments
Labels
0. Needs triage design Related to the design enhancement New feature or request

Comments

@pboguslawski
Copy link

Is your feature request related to a problem? Please describe.

If system has connection to internet disabled by admin, syncing data with social services should be disabled too.

Describe the solution you'd like

Consider hiding Allow updating avatars from social media option in admin settings > Groupware > Calendar if has_internet_connection is false in config.php for cleaner UI.

PR #2913 already disables cron job and user setting in such scenario.

Describe alternatives you've considered

No response

Additional context

No response

@pboguslawski pboguslawski added 0. Needs triage enhancement New feature or request labels Sep 5, 2022
@call-me-matt
Copy link
Member

I personally would feel confused if certain settings do not show up in different setups. Maybe more a question to the design team.

@call-me-matt call-me-matt added the design Related to the design label Sep 5, 2022
@pboguslawski
Copy link
Author

I personally would feel confused if certain settings do not show up in different setups.

There are already other suboptions that are hidden if parent option is disabled. Less unnecessary options, less mess IHMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage design Related to the design enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants