use weights as defined in dataset.yaml #31
Conversation
| movement_periods.random_period: 1.0 | ||
| movement_periods.hold_period: 0.1 | ||
| movement_periods.reach_period: 5.0 | ||
| movement_periods.return_period: 1.0 | ||
| cursor_outlier_segments: 0.0 |
There was a problem hiding this comment.
Does this work? I think movement_periods.reach_period is not present in the random-target sessions.
| "output_mask": pad8(output_mask), | ||
| "output_mask": track_mask8(output_session_index), |
There was a problem hiding this comment.
I went with the pad8 route because that way we can & the evaluation mask with it (if doing eval) and don't have to pass a separate eval mask to the validator.
|
I like the change overall. Left some comments wrt this code being able to run like before. |
|
Also note we're still missing invalid_periods here. Leaving it up to you to decide whether to have a separate PR for that. |
|
Sounds good, I wanted to make a quick draft of the overall concept. Since you agree with the change overall, I will go ahead and implement it! The |
It was only outliers that had weight 0. Invalid trials had weight 0.1 |
No description provided.