[docs-infra] Move BrandingCssVarsProvider to _app.js#47721
Draft
Janpot wants to merge 11 commits intomui:masterfrom
Draft
[docs-infra] Move BrandingCssVarsProvider to _app.js#47721Janpot wants to merge 11 commits intomui:masterfrom
Janpot wants to merge 11 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-47721--material-ui.netlify.app/ Bundle size report
|
Member
As far as I know, we can't do this change because we need docs/pages/_app.js to be barebone so when we create paygrounds we see default behaviors, e.g. theme of our components. There is probably a root cause that we need to fix for our users too anyway? |
Member
Author
|
yeah, change of tac. Exporting a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make branding theme provider reusable without:
<NextNProgressBar />,<CssBaseline />,<SkipLink />...)The goal is to be able to reuse as much as possible from the branding theme when we style things like the cookiebanner which should appear on every page, but live outside of the main branding theme provider