[docs-infra] Reapply Cookie Banner with Design Fixes#47744
Open
dav-is wants to merge 12 commits intomui:masterfrom
Open
[docs-infra] Reapply Cookie Banner with Design Fixes#47744dav-is wants to merge 12 commits intomui:masterfrom
dav-is wants to merge 12 commits intomui:masterfrom
Conversation
dav-is
added
type: enhancement
Netlify deploy previewhttps://deploy-preview-47744--material-ui.netlify.app/ Bundle size report
|
Member
|
I've updated #47721. I propose we wrap the cookiebanner in this theme provider so that we inherit most of the styling from the branding theme instead of trying to recreate it. This ensures maximum compatibility with the them and prevents drift over time. |
…ial-ui into davis/reapply-cookie-banner
Member
Author
|
@Janpot ok, I applied your PR and it seems to be working |
noraleonte
approved these changes
Feb 16, 2026
Contributor
noraleonte
left a comment
noraleonte
left a comment
There was a problem hiding this comment.
From what I see the dark theme and the docs theme are applying correctly now
Leaving just a few nits about the original copy and some small design tweaks. After that, LGTM 👌
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Connor Davis <mail@connordav.is>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #47445 with design fixes
https://deploy-preview-47744--material-ui.netlify.app/
PR on X repo: