Skip to content

fix(data-grid): align icon slot naming and add pagination icon slots #47719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claytonlin1110 wants to merge 1 commit into
base: master
Choose a base branch
from
+58 −17
Open

fix(data-grid): align icon slot naming and add pagination icon slots #47719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions docs/pages/experiments/docs/data-grid-premium-translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,18 +1506,19 @@
"columnMenuAggregationIcon": "Icon displayed in column menu for aggregation",
"columnMenuClearIcon": "Icon displayed in column menu for clearing values",
"columnMenuFilterIcon": "Icon displayed in column menu for filter",
"columnMenuGroupIcon": "Icon displayed in column menu for grouping",
"columnMenuGroupIcon": "Icon displayed in column menu for grouping. This icon toggles to columnMenuUngroupIcon when the column is already grouped.",
"columnMenuHideIcon": "Icon displayed in column menu for hiding column",
"columnMenuIcon": "Icon displayed on the side of the column header title to display the filter input component.",
"columnMenuManageColumnsIcon": "Icon displayed in column menu for showing all columns",
"columnMenuPinLeftIcon": "Icon displayed in column menu for left pinning",
"columnMenuPinRightIcon": "Icon displayed in column menu for right pinning",
"columnMenuManageColumnsIcon": "Icon displayed in column menu for showing all columns. Deprecated: Use columnSelectorIcon instead for unified configuration.",
"columnMenuPinIcon": "Icon displayed in column menu for pinning/unpinning columns. This icon toggles based on the current pin state (unpinned -> pin left, pin left -> pin right, pin right -> unpinned).",
"columnMenuPinLeftIcon": "Icon displayed in column menu for left pinning. Deprecated: Use columnMenuPinIcon with toggle pattern instead.",
"columnMenuPinRightIcon": "Icon displayed in column menu for right pinning. Deprecated: Use columnMenuPinIcon with toggle pattern instead.",
"columnMenuSortAscendingIcon": "Icon displayed in column menu for ascending sort",
"columnMenuSortDescendingIcon": "Icon displayed in column menu for descending sort",
"columnMenuUngroupIcon": "Icon displayed in column menu for ungrouping",
"columnMenuUngroupIcon": "Icon displayed in column menu for ungrouping. This icon is shown when the column is already grouped, replacing columnMenuGroupIcon.",
"columnReorderIcon": "Icon displayed on the column reorder button.",
"columnResizeIcon": "Icon displayed in between two column headers that allows to resize the column header.",
"columnSelectorIcon": "Icon displayed on the column menu selector tab.",
"columnSelectorIcon": "Icon displayed on the column menu selector tab and in the column menu for showing all columns. This is the unified icon for column selection functionality.",
"columnSortedAscendingIcon": "Icon displayed on the side of the column header title when sorted in ascending order.",
"columnSortedDescendingIcon": "Icon displayed on the side of the column header title when sorted in descending order.",
"columnUnsortedIcon": "Icon displayed on the side of the column header title when unsorted.",
Expand All @@ -1531,7 +1532,7 @@
"filterPanel": "Filter panel component rendered when clicking the filter button.",
"filterPanelAddIcon": "Icon displayed for deleting the filter from filter panel.",
"filterPanelDeleteIcon": "Icon displayed for deleting the filter from filter panel.",
"filterPanelRemoveAllIcon": "Icon displayed for deleting all the active filters from filter panel.",
"filterPanelDeleteAllIcon": "Icon displayed for deleting all the active filters from filter panel.",
Copy link
Contributor

@arminmeh arminmeh Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for the next major?

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think so, renaming the slot is a breaking change which described in the issue, so it should go in the next major.

Copy link
Contributor

@arminmeh arminmeh Feb 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelengelen @silviuaavram
does this mean that the PR cannot be merged to master?

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelengelen Could you please answer here? ^^

Copy link
Member

@michelengelen michelengelen Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claytonlin1110 not yet ... we haven't prepared the v8.x branch yet and did not start work on the next major. I did add the breaking change label and added it to the v9 Milestone (freshly created) so we don't lose track of this

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any branch that we can merge to? rather than 'master'?

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelengelen

"footer": "Footer component rendered at the bottom of the grid viewport.",
"footerRowCount": "Row count component rendered in the footer",
"groupingCriteriaCollapseIcon": "Icon displayed on the grouping column when the children are expanded",
Expand All @@ -1545,6 +1546,10 @@
"noRowsOverlay": "No rows overlay component rendered when the grid has no rows.",
"openFilterButtonIcon": "Icon displayed on the open filter button present in the toolbar by default.",
"pagination": "Pagination component rendered in the grid footer by default.",
"paginationFirstIcon": "Icon displayed on the first page button in pagination.",
"paginationPreviousIcon": "Icon displayed on the previous page button in pagination.",
"paginationNextIcon": "Icon displayed on the next page button in pagination.",
"paginationLastIcon": "Icon displayed on the last page button in pagination.",
"panel": "Panel component wrapping the filters and columns panels.",
"preferencesPanel": "PreferencesPanel component rendered inside the Header component.",
"quickFilterClearIcon": "Icon displayed on the quick filter reset input.",
Expand Down
56 changes: 46 additions & 10 deletions docs/pages/experiments/docs/data-grid-premium.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@
{
"class": null,
"name": "columnMenuGroupIcon",
"description": "Icon displayed in column menu for grouping",
"description": "Icon displayed in column menu for grouping. This icon toggles to columnMenuUngroupIcon when the column is already grouped.",
"default": "GridGroupWorkIcon"
},
{
Expand All @@ -774,20 +774,32 @@
{
"class": null,
"name": "columnMenuManageColumnsIcon",
"description": "Icon displayed in column menu for showing all columns",
"default": "GridViewColumnIcon"
"description": "Icon displayed in column menu for showing all columns. Deprecated: Use columnSelectorIcon instead for unified configuration.",
"default": "GridViewColumnIcon",
"deprecated": true,
"deprecationInfo": "Use the <code>columnSelectorIcon</code> slot instead for unified configuration."
},
{
"class": null,
"name": "columnMenuPinLeftIcon",
"description": "Icon displayed in column menu for left pinning",
"default": "GridPushPinLeftIcon"
"description": "Icon displayed in column menu for left pinning. Deprecated: Use columnMenuPinIcon with toggle pattern instead.",
"default": "GridPushPinLeftIcon",
"deprecated": true,
"deprecationInfo": "Use the <code>columnMenuPinIcon</code> slot instead, which toggles based on pin state."
},
{
"class": null,
"name": "columnMenuPinRightIcon",
"description": "Icon displayed in column menu for right pinning",
"default": "GridPushPinRightIcon"
"description": "Icon displayed in column menu for right pinning. Deprecated: Use columnMenuPinIcon with toggle pattern instead.",
"default": "GridPushPinRightIcon",
"deprecated": true,
"deprecationInfo": "Use the <code>columnMenuPinIcon</code> slot instead, which toggles based on pin state."
},
{
"class": null,
"name": "columnMenuPinIcon",
"description": "Icon displayed in column menu for pinning/unpinning columns. This icon toggles based on the current pin state (unpinned -> pin left, pin left -> pin right, pin right -> unpinned).",
"default": "GridPushPinIcon"
},
{
"class": null,
Expand All @@ -804,7 +816,7 @@
{
"class": null,
"name": "columnMenuUngroupIcon",
"description": "Icon displayed in column menu for ungrouping",
"description": "Icon displayed in column menu for ungrouping. This icon is shown when the column is already grouped, replacing columnMenuGroupIcon.",
"default": "GridWorkspacesIcon"
},
{
Expand All @@ -822,7 +834,7 @@
{
"class": null,
"name": "columnSelectorIcon",
"description": "Icon displayed on the column menu selector tab.",
"description": "Icon displayed on the column menu selector tab and in the column menu for showing all columns. This is the unified icon for column selection functionality.",
"default": "GridColumnIcon"
},
{
Expand Down Expand Up @@ -905,7 +917,7 @@
},
{
"class": null,
"name": "filterPanelRemoveAllIcon",
"name": "filterPanelDeleteAllIcon",
"description": "Icon displayed for deleting all the active filters from filter panel.",
"default": "GridDeleteForeverIcon"
},
Expand Down Expand Up @@ -987,6 +999,30 @@
"description": "Pagination component rendered in the grid footer by default.",
"default": "Pagination"
},
{
"class": null,
"name": "paginationFirstIcon",
"description": "Icon displayed on the first page button in pagination.",
"default": "FirstPageIcon"
},
{
"class": null,
"name": "paginationPreviousIcon",
"description": "Icon displayed on the previous page button in pagination.",
"default": "NavigateBeforeIcon"
},
{
"class": null,
"name": "paginationNextIcon",
"description": "Icon displayed on the next page button in pagination.",
"default": "NavigateNextIcon"
},
{
"class": null,
"name": "paginationLastIcon",
"description": "Icon displayed on the last page button in pagination.",
"default": "LastPageIcon"
},
{
"class": null,
"name": "panel",
Expand Down
Loading