Skip to content

Comments

fix(data-grid): align icon slot naming and add pagination icon slots#47719

Open
claytonlin1110 wants to merge 1 commit intomui:masterfrom
claytonlin1110:fix/data-grid-icon-usage-enhancements
Open

fix(data-grid): align icon slot naming and add pagination icon slots#47719
claytonlin1110 wants to merge 1 commit intomui:masterfrom
claytonlin1110:fix/data-grid-icon-usage-enhancements

Conversation

@claytonlin1110
Copy link

@claytonlin1110 claytonlin1110 commented Feb 5, 2026 •
edited
Loading

Changes

  • Pagination icons: Document new slots paginationFirstIcon, paginationPreviousIcon, paginationNextIcon, paginationLastIcon so pagination icons can be customized via DataGrid slots.
  • Filter panel naming: Rename filterPanelRemoveAllIcon → filterPanelDeleteAllIcon for consistency with filterPanelDeleteIcon.
  • Column selector: Treat columnSelectorIcon as the single configuration point; deprecate columnMenuManageColumnsIcon in docs.
  • Pinned columns: Document columnMenuPinIcon (toggle by pin state) and deprecate columnMenuPinLeftIcon / columnMenuPinRightIcon.
  • Grouping: Clarify in docs that grouping uses a toggle pattern between columnMenuGroupIcon and columnMenuUngroupIcon.

Files

  • docs/pages/experiments/docs/data-grid-premium.json
  • docs/pages/experiments/docs/data-grid-premium-translation.json

Note

This issue requires changes on mui-x too:
mui/mui-x#21237

Closes #47117

@mui-bot
Copy link

mui-bot commented Feb 5, 2026 •
edited
Loading

Netlify deploy preview

https://deploy-preview-47719--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against eb4f277

@zannager zannager added scope: data grid Changes related to the data grid. customization: theme Higher level theming customizability. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Feb 6, 2026
@claytonlin1110
Copy link
Author

claytonlin1110 commented Feb 8, 2026

@michelengelen Please review

@zannager zannager added the scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI label Feb 9, 2026
@claytonlin1110
Copy link
Author

claytonlin1110 commented Feb 9, 2026

@michelengelen Had a chance to review this?

@michelengelen
Copy link
Member

michelengelen commented Feb 9, 2026

@michelengelen Had a chance to review this?

Not yet... I did add 2 other reviewers which might speed up the process.

@claytonlin1110
Copy link
Author

claytonlin1110 commented Feb 10, 2026

@MBilalShafi @arminmeh Please feel free to review this PR.

arminmeh
arminmeh reviewed Feb 10, 2026
View reviewed changes
docs/pages/experiments/docs/data-grid-premium-translation.json
"filterPanelAddIcon": "Icon displayed for deleting the filter from filter panel.",
"filterPanelDeleteIcon": "Icon displayed for deleting the filter from filter panel.",
"filterPanelRemoveAllIcon": "Icon displayed for deleting all the active filters from filter panel.",
"filterPanelDeleteAllIcon": "Icon displayed for deleting all the active filters from filter panel.",
Copy link
Contributor

@arminmeh arminmeh Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for the next major?

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think so, renaming the slot is a breaking change which described in the issue, so it should go in the next major.

Copy link
Contributor

@arminmeh arminmeh Feb 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelengelen @silviuaavram
does this mean that the PR cannot be merged to master?

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelengelen Could you please answer here? ^^

Copy link
Member

@michelengelen michelengelen Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claytonlin1110 not yet ... we haven't prepared the v8.x branch yet and did not start work on the next major. I did add the breaking change label and added it to the v9 Milestone (freshly created) so we don't lose track of this

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any branch that we can merge to? rather than 'master'?

Copy link
Author

@claytonlin1110 claytonlin1110 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelengelen

@claytonlin1110 claytonlin1110 mentioned this pull request Feb 10, 2026
Open
@michelengelen michelengelen added the breaking change Introduces changes that are not backward compatible. label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michelengelen michelengelen Awaiting requested review from michelengelen

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

@arminmeh arminmeh Awaiting requested review from arminmeh

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. customization: theme Higher level theming customizability. scope: data grid Changes related to the data grid. scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

Material UI v9 (draft)

Development

Successfully merging this pull request may close these issues.

[data grid] Icon usage enhancements

5 participants

@claytonlin1110 @mui-bot @michelengelen @arminmeh @zannager