Skip to content

feat: add mparticle to launcher integration name#16

Closed
crisryantan wants to merge 21 commits intodevelopmentfrom
feat/NI-746-add-mparticle-to-integration-name
Closed

feat: add mparticle to launcher integration name#16
crisryantan wants to merge 21 commits intodevelopmentfrom
feat/NI-746-add-mparticle-to-integration-name

Conversation

@crisryantan
Copy link
Contributor

Summary

I've improved the version referencing in the mParticle-Rokt integration by:

  1. Adding the @rollup/plugin-replace plugin to properly inject the package version at build time
  2. Updated the rollup configuration to get actual version from package.json
  3. Modified the string concatenation syntax in initialization.js

These changes ensure that the integration properly identifies itself with its version number when creating the Rokt launcher, allowing for better tracking and debugging of integration versions in production.

Testing Plan

This has been tested by:

  1. Verifying the syntax is valid JavaScript that works in all browser environments
  2. Confirming the rollup configuration correctly imports and uses the package.json version

@crisryantan crisryantan changed the base branch from main to development March 31, 2025 04:46
@crisryantan crisryantan force-pushed the feat/NI-746-add-mparticle-to-integration-name branch from 45fe2db to 31b8307 Compare March 31, 2025 05:19
@crisryantan crisryantan changed the base branch from development to feat/SQDSDKS-7159-user-filtering April 2, 2025 04:30
@alexs-mparticle alexs-mparticle changed the base branch from feat/SQDSDKS-7159-user-filtering to development April 2, 2025 14:29
@alexs-mparticle alexs-mparticle force-pushed the feat/NI-746-add-mparticle-to-integration-name branch from 85373b8 to f6e9f05 Compare April 2, 2025 19:15
Copy link
Collaborator

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending confirmation of E2E testing now that's it's been rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants