feat: add mparticle to launcher integration name#19
Merged
crisryantan merged 2 commits intodevelopmentfrom Apr 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the mParticle-Rokt integration by updating how version information is injected and propagated throughout the build and runtime processes.
- Integrates version replacement via Rollup and the package.json version.
- Modifies string concatenation in initialization and launcher creation to include version details.
- Updates test cases and Rollup configurations to support the new version handling.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/src/tests.js | Adds a new method to return the version and verifies the integrationName format. |
| src/Rokt-Kit.js | Concatenates strings to form integrationName using runtime and build-time version values. |
| rollup.test.config.js | Updates plugins for JSON import support in tests. |
| rollup.config.js | Introduces version replacement and JSON plugin in the Rollup config. |
Files not reviewed (1)
- package.json: Language not supported
rmi22186
approved these changes
Apr 3, 2025
Collaborator
rmi22186
left a comment
There was a problem hiding this comment.
LGTM. pending testing of AI's comment in the test file
crisryantan
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've improved the version referencing in the mParticle-Rokt integration by:
Restores #16
Testing Plan
This has been tested by: