Skip to content

feat: add mparticle to launcher integration name#19

Merged
crisryantan merged 2 commits intodevelopmentfrom
feat/NI-746-add-mparticle-to-integration-name
Apr 4, 2025
Merged

feat: add mparticle to launcher integration name#19
crisryantan merged 2 commits intodevelopmentfrom
feat/NI-746-add-mparticle-to-integration-name

Conversation

@alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Apr 3, 2025

Summary

I've improved the version referencing in the mParticle-Rokt integration by:

  • Adding the rollup/plugin-replace plugin to properly inject the package version at build time
  • Updated the rollup configuration to get actual version from package.json
  • Modified the string concatenation syntax in initialization.js
  • These changes ensure that the integration properly identifies itself with its version number when creating the Rokt launcher, allowing for better tracking and debugging of integration versions in production.

Restores #16

Testing Plan

This has been tested by:

  • Verifying the syntax is valid JavaScript that works in all browser environments
  • Confirming the rollup configuration correctly imports and uses the package.json version

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the mParticle-Rokt integration by updating how version information is injected and propagated throughout the build and runtime processes.

  • Integrates version replacement via Rollup and the package.json version.
  • Modifies string concatenation in initialization and launcher creation to include version details.
  • Updates test cases and Rollup configurations to support the new version handling.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

File Description
test/src/tests.js Adds a new method to return the version and verifies the integrationName format.
src/Rokt-Kit.js Concatenates strings to form integrationName using runtime and build-time version values.
rollup.test.config.js Updates plugins for JSON import support in tests.
rollup.config.js Introduces version replacement and JSON plugin in the Rollup config.
Files not reviewed (1)
  • package.json: Language not supported

Copy link
Collaborator

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. pending testing of AI's comment in the test file

@alexs-mparticle alexs-mparticle requested a review from Copilot April 3, 2025 20:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@alexs-mparticle alexs-mparticle requested a review from Copilot April 3, 2025 20:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@crisryantan crisryantan merged commit 1e3a6de into development Apr 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants