-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new breed classifications and breeds for Cellosaurus request #194
Conversation
@sabrinatoro please review this PR that adds new breed classification terms and new fish, xenopus and zebra finch breeds. Please see issue #187 and #181 for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- should we put all of these new breeds in the "livestock" spreadsheet? Maybe we need a new one?
- please see comments. It might be easier to review these changes together
Added new component for "other breeds", updated high level classification and added more Cellosaurus NTRs/synonyms to existing terms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @katiermullen! It looks great!
I am approving and merging the PR.
Note that I saw that "common carp breed" does not have any children. I think it is ok because the term requested map to species and not breeds.
Closes #187
Addresses #181