Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new breed classifications and breeds for Cellosaurus request #194

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

katiermullen
Copy link
Collaborator

Closes #187

Addresses #181

@katiermullen katiermullen marked this pull request as draft August 7, 2024 03:46
@katiermullen katiermullen self-assigned this Aug 7, 2024
@katiermullen katiermullen marked this pull request as ready for review August 7, 2024 12:52
@katiermullen
Copy link
Collaborator Author

@sabrinatoro please review this PR that adds new breed classification terms and new fish, xenopus and zebra finch breeds. Please see issue #187 and #181 for more information.

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • should we put all of these new breeds in the "livestock" spreadsheet? Maybe we need a new one?
  • please see comments. It might be easier to review these changes together

src/ontology/components/highlevelclass.tsv Outdated Show resolved Hide resolved
src/ontology/components/livestockbreeds.tsv Outdated Show resolved Hide resolved
src/ontology/components/livestockbreeds.tsv Outdated Show resolved Hide resolved
Added new component for "other breeds", updated high level classification and added more Cellosaurus NTRs/synonyms to existing terms.
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @katiermullen! It looks great!
I am approving and merging the PR.

Note that I saw that "common carp breed" does not have any children. I think it is ok because the term requested map to species and not breeds.

@sabrinatoro sabrinatoro merged commit c9830ec into master Aug 9, 2024
1 check passed
@sabrinatoro sabrinatoro deleted the 240806-updates branch August 9, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new NCBI Taxon for Cellosaurus request
2 participants