New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for DADIS sync workflow #148

Merged

marius-mather merged 2 commits into master from fix_dadis_sync

Feb 8, 2024

Collaborator

marius-mather commented Feb 8, 2024

This PR contains fixes for a couple of issues with the DADIS sync workflow:

The make jobs did not seem to work since they were using an existing filename, so make was reporting "nothing to be done". I have not worked much with make so you may need to check that my updated version makes sense
The scripts had issues when trying to read from and write to the same filename, since they need to copy the header from the input file. I've updated it so we create a temporary output file first, then copy to the final destination

marius-mather added 2 commits

February 8, 2024 11:10


          Use task name, not file name, in makefile, since we want to update an…

b62770e

… existing file


          Need to write output to a temporary file first, so we can overwrite t…

2be13e8

…he input file

matentzn approved these changes

View reviewed changes

Member

matentzn left a comment

Didnt look in detail at the python code, but approved for changes to makefile for sure!

marius-mather merged commit 2678666 into master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet