Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title cleaning updates #152

Open
wants to merge 1 commit into
base: abbrevs-alt-n-included
Choose a base branch
from

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Sep 23, 2024

Updates

Title cleaning updates

  • Update: Refactor: Cleaned some redundancy in how this was being called. Simplified code. Modularized other parts of code.

Additional info

Context:
This PR began to address #132 (comment), but then scope increased as I realized where the redundancy lie.

Note to self: If we handle and merge #132 first, change the base of this to main.

@joeflack4 joeflack4 marked this pull request as draft September 23, 2024 03:22
- Update: Refactor: Cleaned some redundancy in how this was being called. Simplified code. Modularized other parts of code.
@joeflack4 joeflack4 self-assigned this Sep 23, 2024
@joeflack4 joeflack4 added code quality enhancement New feature or request labels Sep 23, 2024
@joeflack4 joeflack4 changed the base branch from main to abbrevs-alt-n-included September 23, 2024 03:34
@joeflack4 joeflack4 removed the enhancement New feature or request label Sep 23, 2024
@joeflack4 joeflack4 marked this pull request as ready for review September 23, 2024 03:36
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Build"

I created an omim.owl before and after these changes, and ran a diff, crossing my fingers, expecting and hoping for there to be no difference. And there wasn't! I uploaded the before, after, and diff to google drive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant