Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge cytochrome-c oxidase deficiency disease #8661

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

nicolevasilevsky
Copy link
Member

close #7438

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky the Subclasses of the obsoleted terms were removed instead of being replaced by the new ID.
These SubClassOf seemed OK to me. If you did remove them on purpose, could you please add a note with the reasons to remove them, and add them as "excluded subclass of". If these were not on purpose, please add them back (and let's take a note of it and test as there might be a bug in the merge pipeline).
Thank you

@@ -559595,7 +559590,6 @@ subset: gard_rare {source="MONDO:GARD"}
subset: rare
xref: DOID:0081377 {source="MONDO:equivalentTo"}
is_a: MONDO:0005336 {source="https://orcid.org/0000-0002-4142-7153"} ! myopathy
is_a: MONDO:0009068 {source="DOID:0081377"} ! cytochrome-c oxidase deficiency disease
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky I don't think this x-ref should have been removed. It should have been replaced by the "replaced by" ID.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -296798,7 +296762,6 @@ xref: SCTID:722207000 {source="MONDO:equivalentTo"}
xref: UMLS:C2675184 {source="MEDGEN:436369", source="MONDO:equivalentTo", source="MONDO:MEDGEN"}
is_a: MONDO:0001684 {source="MESH:C567195"} ! exocrine pancreatic insufficiency
is_a: MONDO:0002356 {source="MONDO:Redundant", source="Orphanet:199337"} ! pancreas disorder
is_a: MONDO:0009068 ! cytochrome-c oxidase deficiency disease
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky I don't think this x-ref should have been removed. It should have been replaced by the "replaced by" ID.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approving and merging

@sabrinatoro sabrinatoro merged commit 34250ab into master Feb 13, 2025
1 check passed
@sabrinatoro sabrinatoro deleted the issue-7438 branch February 13, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Merge] 'cytochrome-c oxidase deficiency disease' into 'mitochondrial complex IV deficiency, nuclear-type'
2 participants