DO NOT MERGE: Synonym sync: acronym case exception - build #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
added
the
build
9 tasks
joeflack4
commented
Oct 6, 2024
joeflack4
force-pushed
the
syn-sync-acronym-source-case-build
branch
from
ff606ee
to
312389b
Compare
joeflack4
force-pushed
the
syn-sync-acronym-source-case-build
branch
from
312389b
to
14f04b9
Compare
joeflack4
commented
Oct 9, 2024
There was a problem hiding this comment.
General review
Overall build LGTM!
New synonym sync outputs were ran recently before this build and are in the Google sheet. Those same outputs look good in this build.
Build stats
Build time was unusually high. About 7 hours. I haven't yet analyzed why that might be the case, though. I did notice that it seemed to be stuck on the synonym sync for Ordo for a bit, but IDK why that'd be the case. Normally the synonym sync Python scripts take about 45 seconds to complete for all sources. I might want to re-run part of / whole pipeline to sanity check performance. I wonder if my mac went to sleep at some point, though it shouldn't when it's plugged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build for:
Maybe this build isn't entirely necessary, given the simple changes of #671. But we are about done with this round of synonym sync and about to merge it, and it needs a build first. But this feature branch is still open, so I ought to build here instead.
We do however have some synony-related OMIM changes (monarch-initiative/omim#132) still yet to be merged. Not sure if we need to run a build on #93 when those changes are merged.