-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded traits on sys types #51
Conversation
Previously `Send` and `Sync` were declared on the sys versions of `Mutex`, `RwLock`, and `Condvar`. Per https://doc.rust-lang.org/nomicon/send-and-sync.html these traites are automatically derived when composed entirely of `Send`/`Sync` types. The types from `mc-sgx-tstdc` do derive `Send` and `Sync` so the redeclaring of the traits here is unneeded.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## nick/prevent-recursive-panic #51 +/- ##
=============================================================
Coverage 92.87% 92.87%
=============================================================
Files 9 9
Lines 323 323
=============================================================
Hits 300 300
Misses 23 23 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the explanation in the PR description.
Previously
Send
andSync
were declared on the sys versions ofMutex
,RwLock
, andCondvar
. Perhttps://doc.rust-lang.org/nomicon/send-and-sync.html these traites are
automatically derived when composed entirely of
Send
/Sync
types. Thetypes from
mc-sgx-tstdc
do deriveSend
andSync
so the redeclaringof the traits here is unneeded.