Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded traits on sys types #51

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

Previously Send and Sync were declared on the sys versions of
Mutex, RwLock, and Condvar. Per
https://doc.rust-lang.org/nomicon/send-and-sync.html these traites are
automatically derived when composed entirely of Send/Sync types. The
types from mc-sgx-tstdc do derive Send and Sync so the redeclaring
of the traits here is unneeded.

Previously `Send` and `Sync` were declared on the sys versions of
`Mutex`, `RwLock`, and `Condvar`. Per
https://doc.rust-lang.org/nomicon/send-and-sync.html these traites are
automatically derived when composed entirely of `Send`/`Sync` types. The
types from `mc-sgx-tstdc` do derive `Send` and `Sync` so the redeclaring
of the traits here is unneeded.
@codecov-commenter
Copy link

Codecov Report

Merging #51 (d141270) into nick/prevent-recursive-panic (d97b920) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                      Coverage Diff                      @@
##           nick/prevent-recursive-panic      #51   +/-   ##
=============================================================
  Coverage                         92.87%   92.87%           
=============================================================
  Files                                 9        9           
  Lines                               323      323           
=============================================================
  Hits                                300      300           
  Misses                               23       23           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin mentioned this pull request Jan 31, 2023
12 tasks
Copy link
Contributor

@samdealy samdealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the explanation in the PR description.

Base automatically changed from nick/prevent-recursive-panic to main February 1, 2023 22:33
@nick-mobilecoin nick-mobilecoin merged commit 3e05653 into main Feb 1, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/remove-redundant-traits branch February 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra-Small PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants