Add panicking::panic_count to mc-sgx-panic

[nick-mobilecoin]

No description provided.

[nick-mobilecoin]

Current dependencies on/for this PR:

• main
  • PR Update CI for SGX SDK action update #14
    • PR Move panic to panic/abort #13
      • PR Add untrusted side of stderr from enclave #15
        • PR Add mc-sgx-io #22
          • PR Add mc-sgx-panic-log #24
            • PR Add mc-sgx-panic crate for common panic handling #30
              • PR Add panicking::panic_count to mc-sgx-panic #31 👈
                • PR Update CODEOWNERS file #32
                  • PR Add panicking::panicking() function #33
                  • PR Add public function thread::panicking() #34
                  • PR Add mc-sgx-sync crate #35
                  • PR Add poison.rs to mc-sgx-sync crate #36
                  • PR Add sys module to mc-sgx-sync #39
                  • PR Add mutex.rs to mc-sgx-sync crate #40
                  • PR Use a static buffer for panic messages #41
                  • PR Add mc-sgx-sync::sys::locks::Condvar #42
                  • PR Add Condvar to mc-sgx-sync crate #43
                  • PR Add mc-sgx-sync::sys::locks::RwLock #44
                  • PR Add RwLock to mc-sgx-sync #45
                  • PR Add example usage for mc-sgx-sync and std::sync #46
                  • PR Merge panic-abort and panic-log crates into mc-sgx-panic #48
                  • PR Prevent recursive panics from happening #50
                  • PR Remove unneeded traits on sys types #51
        • PR Rename mc-sgx-io to mc-sgx-io-untrusted #21

This comment was auto-generated by Graphite.

[nick-mobilecoin]

Moved back to a draft, with the failures on, https://github.com/mobilecoinfoundation/sgx-std/actions/runs/3887979469/jobs/6634849726, it seems pretty clear that the value is not being thread local

---- panicking::test::decrementing_one_at_a_time stdout ----
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `5`,
 right: `4`', panic/src/panicking.rs:100:9

---- panicking::test::incrementing_one_at_a_time stdout ----
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `6`,
 right: `1`', panic/src/panicking.rs:88:9

---- panicking::test::initialized_to_0 stdout ----
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `6`,
 right: `0`', panic/src/panicking.rs:68:9

[nick-mobilecoin]

Doing some debugging have the side by side of what rust std does and what is being attempted in this PR https://godbolt.org/z/r3c37Tqxh
I also removed no_std and tried to do what rust std does and got the same failure...

[nick-mobilecoin]

moved out of draft, found problem that was causing llvm-cov to fail, added explanation in code at https://github.com/mobilecoinfoundation/sgx-std/pull/31/files#diff-0ce129c061b49b04073e4988bbaca5999d4b7148812aff7489623ab6f53edad8R66

        /// By default each test runs in a separate thread thus having their own
        /// thread local copy of `LOCAL_PANIC_COUNT`. However per
        /// https://github.com/rust-lang/rust/issues/58907 when running single
        /// threaded the thread is re-used for each test execution so the value
        /// should be reset to a known value on each test. This also means that
        /// there isn't a reliable way to test that 0 is the true initial value.

[awygle]

LGTM

[jcape]

Note: intel/linux-sgx#283

[nick-mobilecoin]

Note: intel/linux-sgx#283

I looked through the current doc, https://download.01.org/intel-sgx/sgx-linux/2.18/docs/Intel_SGX_Developer_Reference_Linux_2.18_Open_Source.pdf trying to get a feel of how the threading worked, but wasn't able to piece it together.
If I'm reading the issue correctly, for panics, it will only be an issue if threads are bound to the untrusted thread, and the untrusted side assumes each ecall is a fresh state

[codecov-commenter]

Codecov Report

Merging #31 (c93e6bf) into main (63c237b) will increase coverage by 3.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   88.09%   91.71%   +3.61%     
==========================================
  Files           5        6       +1     
  Lines         126      181      +55     
==========================================
+ Hits          111      166      +55     
  Misses         15       15              

Impacted Files	Coverage Δ
panic/src/lib.rs	100.00% <ø> (ø)
panic/src/panicking.rs	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[NotGyro]

This looks good to me.

[nick-mobilecoin]

✅ This pull request merged successfully as part of a Graphite job
Stack job ID: 174FRuRmqv3ul7Wrh6cz.
See details on graphite.dev