Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reloop Beatmix gen.1 documentation page added. #598
base: 2.3
Are you sure you want to change the base?
Reloop Beatmix gen.1 documentation page added. #598
Changes from 3 commits
50d1365
41ed7f3
9120bbe
5e2d2e3
1127021
b659ece
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no tempo tap (before mixxxdj/mixxx#12104 is merged ; )
You mean BPM tap https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[ChannelN]-bpm_tap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still the case? I can't spot where this is controlled in the manual.
Also, I think "safe" is up to the users here, they can decide whether tracks can be loaded into playing decks, and if yes, if the deck keeps playing, see Preferences -> Decks.
Futrhermore, LED off doesn't mean the button is inactive / unresponsive, and after a while with a controller you don't actually look at browse/load controls anymore while operating due to muscle memory (and dial/load are so close)
Also LED ON usually means something IS loaded. (samplers, effec ON)
Long story short: I think it would be better to bind the LED to "track loaded".
And make Shift+Load do eject as mentioned in the mapping PR