Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): blueskyの投稿埋め込み表示に対応 #14933

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

image

Why

Fix #14931

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 36.90476% with 53 lines in your changes missing coverage. Please review.

Project coverage is 18.88%. Comparing base (68175bc) to head (f7f22b8).

Files with missing lines Patch % Lines
packages/frontend/src/components/MkUrlPreview.vue 36.90% 53 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14933       +/-   ##
============================================
- Coverage    37.76%   18.88%   -18.88%     
============================================
  Files         1601      762      -839     
  Lines       203886   110698    -93188     
  Branches      3711     1233     -2478     
============================================
- Hits         76988    20904    -56084     
+ Misses      126256    89209    -37047     
+ Partials       642      585       -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@saschanaz
Copy link
Member

コンフリクト解消

コンフリクトまた起きてしまってまして

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embed.bsky.appとほぼ同じ行動してるのでいいと思います

(didの部分はちょっと面倒)

packages/frontend/src/components/MkUrlPreview.vue Outdated Show resolved Hide resolved
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動き確認しました

packages/frontend/src/components/MkUrlPreview.vue Outdated Show resolved Hide resolved
@saschanaz
Copy link
Member

(bsky、ダークモードをサポートしないのが不満)

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@saschanaz
Copy link
Member

(そろそろマージしてもいいかと)

@kakkokari-gtyih
Copy link
Contributor Author

(bsky、ダークモードをサポートしないのが不満)

対応した
bluesky-social/social-app#6912

@kakkokari-gtyih
Copy link
Contributor Author

(bsky、ダークモードをサポートしないのが不満)

対応した bluesky-social/social-app#6912

bluesky-social/social-app#7186 でデフォルトのカラーモードがライト固定になるっぽいので調整が必要(とはいっても?colorMode=<auto|light|dark>をつけるだけでよい)

@saschanaz
Copy link
Member

試してみて分かったことですが

  • bsky側のmin-widthが多すぎてスマホで見たら画面を超えてしまう
  • bsky.brid.gyから投げられる引用の場合、リンクと引用が共存し、MkNoteDetailedで両方見えてしまう

事があります

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Jan 11, 2025

bsky側のmin-widthが多すぎてスマホで見たら画面を超えてしまう

向こうにバグ報告するべきかも

bsky.brid.gyから投げられる引用の場合、リンクと引用が共存し、MkNoteDetailedで両方見えてしまう

MkNoteDetailedで埋め込みをデフォルトで開かないようにしても良いかも

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

Blueskyの投稿埋め込みプレビュー
2 participants