-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(frontend): blueskyの投稿埋め込み表示に対応 #14933
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14933 +/- ##
============================================
- Coverage 37.76% 18.88% -18.88%
============================================
Files 1601 762 -839
Lines 203886 110698 -93188
Branches 3711 1233 -2478
============================================
- Hits 76988 20904 -56084
+ Misses 126256 89209 -37047
+ Partials 642 585 -57 ☔ View full report in Codecov by Sentry. |
コンフリクト解消 |
コンフリクトまた起きてしまってまして |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
embed.bsky.appとほぼ同じ行動してるのでいいと思います
(didの部分はちょっと面倒)
コンフリクト解消 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動き確認しました
(bsky、ダークモードをサポートしないのが不満) |
コンフリクト解消 |
(そろそろマージしてもいいかと) |
|
bluesky-social/social-app#7186 でデフォルトのカラーモードがライト固定になるっぽいので調整が必要(とはいっても |
試してみて分かったことですが
事があります |
向こうにバグ報告するべきかも
MkNoteDetailedで埋め込みをデフォルトで開かないようにしても良いかも |
What
Why
Fix #14931
Additional info (optional)
expandTweet
はXのポストだけを指すものではなくなるので、全体の翻訳を当て直すためにkeyを変更したChecklist