Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter doesn't work anymore #30

Open
dacmot opened this issue Aug 31, 2024 · 0 comments · May be fixed by #32
Open

Filter doesn't work anymore #30

dacmot opened this issue Aug 31, 2024 · 0 comments · May be fixed by #32

Comments

@dacmot
Copy link

dacmot commented Aug 31, 2024

Minetest 5.9.0, Ubuntu 22.04, Whynot game, hopper at 18f3711 (edit: also at 0baf36e)

The filter doesn't work as described anymore. Items listed in the filter do go through in the direction of the big V, but items that don't match just accumulate in the 4 storage spot and end up clogging instead going out the secondary output. Toggling the ejection button has no effect.

Here is the setup I used:

screenshot_20240830_204856

And this is what happens:

screenshot_20240830_204912

I bisected the main branch and found the regression was in this commit:

30b565480212299bca9a22ece614ff238777bbb3 is the first bad commit
commit 30b565480212299bca9a22ece614ff238777bbb3
Author: SmallJoker <[email protected]>
Date:   Fri Aug 16 22:58:59 2024 +0200

    Add .luacheckrc and fix its warnings

 .luacheckrc       | 22 ++++++++++++++++++++++
 abms.lua          |  4 ++--
 crafts.lua        | 10 +++++-----
 nodes/chute.lua   |  3 ---
 nodes/hoppers.lua |  8 ++++----
 nodes/sorter.lua  | 47 ++++++++++++++---------------------------------
 utility.lua       |  5 ++---
 7 files changed, 49 insertions(+), 50 deletions(-)
 create mode 100644 .luacheckrc
@dacmot dacmot linked a pull request Sep 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant