Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with filter eject #31

Closed
dacmot opened this issue Sep 3, 2024 · 0 comments · Fixed by #32
Closed

Crash with filter eject #31

dacmot opened this issue Sep 3, 2024 · 0 comments · Fixed by #32

Comments

@dacmot
Copy link
Contributor

dacmot commented Sep 3, 2024

Ubuntu 22.04, Minetest 5.9.0, WhyNot game, hopper at 0baf36e

I removed the secondary exit pipe on the filter (see picture in #30) and now it crashes when I set the filter to eject.

AsyncErr: Lua: Runtime error from mod 'hopper' in callback node_on_timer(): ...minetest/games/whynot-game/mods/tools/hopper/utility.lua:155: attempt to index local 'target_inv_info' (a nil value)
stack traceback:
	...minetest/games/whynot-game/mods/tools/hopper/utility.lua:155: in function 'try_send_item'
	...est/games/whynot-game/mods/tools/hopper/nodes/sorter.lua:192: in function <...est/games/whynot-game/mods/tools/hopper/nodes/sorter.lua:150>

I bisected the main branch and found the regression happened in the following commit:

df5f8d837932dc70a812b850ef9b78ee3733111d is the first bad commit
commit df5f8d837932dc70a812b850ef9b78ee3733111d
Author: Ajrat Makhmutov <[email protected]>
Date:   Sun Jul 21 04:16:35 2024 +0300

    Add multi-node containers support
    
    + remove trailing spaces
    + add new api for extra information about containers

 abms.lua          |  12 ++---
 api.lua           | 130 ++++++++++++++++++++++++++++++++++++++----------------
 nodes/chute.lua   |  12 ++---
 nodes/hoppers.lua |  28 +++++++-----
 nodes/sorter.lua  |  42 +++++++++---------
 utility.lua       |  64 ++++++++++++++++++---------
 6 files changed, 184 insertions(+), 104 deletions(-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant