[vscode-shared] Add outputMarker option to runWorkspaceCommandAsync

[Copilot]

• Explore and understand the codebase structure
• Add outputMarker option to runWorkspaceCommandAsync function
• Update debug-certificate-manager-vscode-extension to use the new option
• Update playwright-local-browser-server-vscode-extension to use the new option
• Build and verify changes compile successfully
• Address feedback: Remove node -p extraction from function - callers provide full command
• Run CodeQL security checker

Summary

This PR refactors the duplicate string marker logic from two VS Code extensions into runWorkspaceCommandAsync.

Changes:

• Added IOutputMarkerOptions interface with prefix and suffix properties
• When outputMarker is provided, the function extracts only the content between the markers from the output
• The function is generic and does not construct any commands - callers provide the full command line
• Updated both extensions to use the new option

Security Summary

No security vulnerabilities detected by CodeQL.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[vscode-shared] Refactor string marking logic into runWorkspaceCommandAsync</issue_title>
<issue_description>runWorkspaceCommandAsync used in two places:

rushstack/vscode-extensions/debug-certificate-manager-vscode-extension/src/extension.ts

Lines 210 to 226 in 98334a9

	const markerPrefix: string = '<<<HOMEDIR_START>>>';
	const markerSuffix: string = '<<<HOMEDIR_END>>>';
	const output: string = await runWorkspaceCommandAsync({
	terminalOptions: { name: 'debug-certificate-manager', hideFromUser: true },
	// Wrapping the desired node output in markers to trim uninteresting shell output.
	commandLine: `node -p "'${markerPrefix}' + require('os').homedir() + '${markerSuffix}'"`,
	terminal
	});
	terminal.writeLine(`Running command to resolve home directory: ${output}`);
	const startIndex: number = output.lastIndexOf(markerPrefix);
	const endIndex: number = output.lastIndexOf(markerSuffix);
	if (startIndex !== -1 && endIndex !== -1 && endIndex > startIndex) {
	homeDir = output.substring(startIndex + markerPrefix.length, endIndex).trim();
	} else {
	throw new Error('Failed to parse home directory from command output');
	}

and

rushstack/vscode-extensions/playwright-local-browser-server-vscode-extension/src/extension.ts

Lines 48 to 62 in 98334a9

	const markerPrefix: string = '<<<TEMPDIR_START>>>';
	const markerSuffix: string = '<<<TEMPDIR_END>>>';
	const output: string = await runWorkspaceCommandAsync({
	terminalOptions: { name: 'playwright-local-browser-server', hideFromUser: true },
	commandLine: `node -p "'${markerPrefix}' + require('node:os').tmpdir() + '${markerSuffix}'"`,
	terminal
	});
	const startIndex: number = output.indexOf(markerPrefix);
	const endIndex: number = output.indexOf(markerSuffix);
	if (startIndex !== -1 && endIndex !== -1 && endIndex > startIndex) {
	tempDir = output.substring(startIndex + markerPrefix.length, endIndex).trim();
	} else {
	throw new Error('Failed to parse temp directory from command output');
	}

with duplicate string marker logic wrapped around the usage of these functions.

We should abstract this as a new option in runWorkspaceCommandAsync so we don't have this extra logic. </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [vscode-shared] Refactor string marking logic into runWorkspaceCommandAsync #5589

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[dmichon-msft]

Per prior conversation regarding the debug certificate manager, to deal with some shells that echo the command to be run, we should be using lastIndexOf instead of indexOf, and also should anchor one from the other.

[dmichon-msft]

Need to explicitly define the behavior when the markers appear multiple times.

[TheLarkInn]

After talking with Bharat we're going to just leave this refactor as is. It doesn't really help much, however we can still refactor to use lastIndexOf() in a separate PR.