[rush] Fix build cache ids when "enableSubpathScan" is enabled#5045
Merged
dmichon-msft merged 1 commit intomicrosoft:mainfrom Dec 14, 2024
Merged
[rush] Fix build cache ids when "enableSubpathScan" is enabled#5045dmichon-msft merged 1 commit intomicrosoft:mainfrom
dmichon-msft merged 1 commit intomicrosoft:mainfrom
Conversation
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
D4N14L
approved these changes
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue with the "enableSubpathScan" experiment where the
--onlyand--impacted-byselection operators would compute incorrect build cache ids and therefore cause cache misses.Details
Computation of build cache ids always requires the file hashes of all dependencies of selected projects, because the cache id is a function of the cache ids of the operation dependencies (approximately).
How it was tested
Enabled the experiment and verified that running
rush build -o worker-pool --verbosewas a cache hit.For comparison, reverted this change and did the same and verified a cache miss.
Impacted documentation
Since the experiment description doesn't specify exactly what filtering is applied, none.