Run isort & black, automaticly check in CI #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
isort-black-ci
branch
from
92ab8ff to
5ef4cf7
Compare
debonte
requested changes
Dec 12, 2023
debonte
requested changes
Dec 15, 2023
|
Sorry for the late update! I've added mypy extension as well in preparation for #301 |
debonte
approved these changes
Feb 13, 2024
|
@debonte Is this good to be merged? |
|
@Avasam, sorry for the delay. I was probably, incorrectly, assuming that you could merge this yourself once it was approved. Thanks for doing this! 💥 |
|
No problem! You're welcome 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart to #301, but with minimal config changes. So you can decide which you want first. There will be slight conflicts but I'll resolve them.
Closes #296