-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automated tests, pass as-is #301
Conversation
Updated with latest review comments! Btw feel free to squash commit once this is accepted. I avoid rebases/force-pushes on GitHub to make it easier on the reviewer to see latest changes. |
…into Update-automated-tests
What is the status of this PR? |
Unless you have any other comment, it's good to be squash-merged on my side if it passes the CI. #301 (comment) and #301 (comment) are more follow-ups than something to be done here. |
I unpinned |
…into Update-automated-tests
matplotlib | ||
mypy==0.950 | ||
# Tools used for testing | ||
docopt-ng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When installing the requirements on a fresh install of Python 3.10, I got the following warning:
DEPRECATION: docopt is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
That led me to docopt/docopt#502 (comment): even docopt organization members are recommending to switch over to docopt-ng due to docopt being unmaintained in the past 6 years (last release 10 years ago)
@Avasam, thanks for your work here! |
Work towards #296
Counterpart to #302 but this only touches configurations and infra. No stub change here except for
stubs/scipy-stubs/optimize/cython_optimize/__init__.pyi
(which is purely a mypy workaround otherwise it wouldn't even run due to same-name modules). So you can decide which you want first. There will be slight conflicts but I'll resolve them.typeCheckingMode
setting from IDE only to pyright configswarn-partial
setting from GitHub actions to pyright configsshow_column_numbers
in mypytests/__init__.py
stubs/scipy-stubs/optimize/cython_optimize/__init__.pyi
to get mypy to runtests/requirements.txt
tests/run_tests.sh
andtests/run_tests.cmd
into a Python script, simplified the commands, and update to run all the teststests/run_formatters.py
to run all code fixers and formatters