-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JSNativeApi.cs #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongin
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a great improvement to the public API surface.
I just have some concerns about keeping conversion APIs for JSBigInt
consistent with other types.
This was referenced Jan 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of the code refactoring that aims to simplify the code and to improve public API.
In this PR we remove the
JSNativeApi.cs
file that mostly had extensions for theJSValue
struct.We still have
JSNativeApi
class in theJSError.cs
file that we can remove in future PR.The key parts of this PR:
JSVativeApi.cs
code is moved inside of theJSValue
struct.JSRuntime
functions inJSValue
is changed to minimize required verifications. New private functionsGetRuntime
andGetCurrentRuntime
returnnapi_env
andnapi_value
in one call.JSNativeApi
is changed to use the newJSValue
functions.JSMarshaller
changes reflect the function changes fromJSNativeApi
static methods toJSValue
instance methods.In the next PRs we should improve the
JSValue
API and API for other classes and structs.E.g. we can move some methods to JS type specific structs.