Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename/refactor JSNativeApi class #176

Closed
jasongin opened this issue Nov 10, 2023 · 1 comment
Closed

Rename/refactor JSNativeApi class #176

jasongin opened this issue Nov 10, 2023 · 1 comment
Assignees
@vmoroz

Comments

@jasongin
Copy link
Member

The JSNativeApi class consists almost entirely of extension methods for JSValue. Either it should be renamed to JSValueExtensions, or the methods should be moved into the JSValue class itself.
@jasongin jasongin self-assigned this Nov 10, 2023
@jasongin jasongin moved this to 🔖 Ready in node-api-dotnet tasks Nov 10, 2023
@jasongin jasongin assigned vmoroz and unassigned jasongin Jan 19, 2024
@jasongin
Copy link
Member Author

Fixed by #187

@jasongin jasongin moved this from 🔖 Ready to 👀 In review in node-api-dotnet tasks Jan 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in node-api-dotnet tasks Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmoroz vmoroz

Labels
None yet
Projects
node-api-dotnet tasks
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmoroz @jasongin