Skip to content

Add missing f-string #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
funkyrailroad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing f-string #1427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flower/api/control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def post(self, workername):
destination=[workername], reply=True)
if response and 'ok' in response[0][workername]:
self.write(dict(message=f"Autoscaling '{workername}' worker "
"(min={min}, max={max})"))
f"(min={min}, max={max})"))
Comment on lines 262 to +263
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The f-string fix is correct, but this creates an inconsistent string concatenation pattern. Consider combining both lines into a single f-string for better readability: f"Autoscaling '{workername}' worker (min={min}, max={max})"

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@auvipy auvipy Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check this?

Copy link
Contributor

@ulgens ulgens Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Copilot's comment matters here. The changed version keeps the original styling/new line.

else:
logger.error(response)
self.set_status(403)
Expand Down
Loading