Add missing f-string #1427
Add missing f-string #1427
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing f-string prefix in an error message format string. The change ensures that variable interpolation works correctly when displaying autoscaling configuration for workers.
- Adds missing
fprefix to the second line of a multi-line f-string
| self.write(dict(message=f"Autoscaling '{workername}' worker " | ||
| "(min={min}, max={max})")) | ||
| f"(min={min}, max={max})")) |
There was a problem hiding this comment.
[nitpick] The f-string fix is correct, but this creates an inconsistent string concatenation pattern. Consider combining both lines into a single f-string for better readability: f"Autoscaling '{workername}' worker (min={min}, max={max})"
There was a problem hiding this comment.
can you please check this?
There was a problem hiding this comment.
I don't think Copilot's comment matters here. The changed version keeps the original styling/new line.
| self.write(dict(message=f"Autoscaling '{workername}' worker " | ||
| "(min={min}, max={max})")) | ||
| f"(min={min}, max={max})")) |
There was a problem hiding this comment.
can you please check this?
|
@auvipy I think this can be merged. |
3 participants
The super easy fix for this:
#1426