Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove keepalived from BMO repository #2228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/build-images-action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,3 @@ jobs:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
build_keepalived:
name: Build keepalived container image
if: github.repository == 'metal3-io/baremetal-operator'
uses: metal3-io/project-infra/.github/workflows/container-image-build.yml@main
with:
image-name: 'keepalived'
dockerfile-directory: resources/keepalived-docker
pushImage: true
secrets:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
16 changes: 0 additions & 16 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -135,19 +135,3 @@ jobs:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
build_keepalived:
permissions:
contents: read
needs: push_release_tags
name: Build keepalived container image
if: github.repository == 'metal3-io/baremetal-operator'
uses: metal3-io/project-infra/.github/workflows/container-image-build.yml@main
with:
image-name: 'keepalived'
dockerfile-directory: resources/keepalived-docker
pushImage: true
ref: ${{ needs.push_release_tags.outputs.release_tag }}
secrets:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ go.work.sum
*.tmp
.DS_Store
.zed*
*.swp

# Tilt files.
.tiltbuild
Expand Down
4 changes: 1 addition & 3 deletions docs/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ Once PR is merged following GitHub actions are triggered:
or a new patch release from the latest release branch, uncheck the box for
latest release. If it is a release candidate (RC) or a beta release,
tick pre-release box.
- GitHub jobs `build_bmo` and `build_keepalived` build release images with the
- GitHub job `build_bmo` build release images with the
release tag, and push them to Quay. Make sure the release tags are visible in
Quay tags pages:
- [BMO](https://quay.io/repository/metal3-io/baremetal-operator?tab=tags)
- [keepalived](https://quay.io/repository/metal3-io/keepalived?tab=tags)
If the new release tag is not available for any of the images, check if the
action has failed and retrigger as necessary.

Expand All @@ -125,7 +124,6 @@ Git tags pushed:
Container images built and tagged at Quay registry:

- [baremetal-operator:v0.x.y](https://quay.io/repository/metal3-io/baremetal-operator?tab=tags)
- [keepalived:v0.x.y](https://quay.io/repository/metal3-io/keepalived?tab=tags)

Files included in the release page:

Expand Down
16 changes: 0 additions & 16 deletions resources/keepalived-docker/Dockerfile

This file was deleted.

20 changes: 0 additions & 20 deletions resources/keepalived-docker/configure-nonroot.sh

This file was deleted.

11 changes: 0 additions & 11 deletions resources/keepalived-docker/manage-keepalived.sh

This file was deleted.

20 changes: 0 additions & 20 deletions resources/keepalived-docker/sample.keepalived.conf

This file was deleted.