🌱 E2E vbmctl and ssh boot check refactor #2223
Conversation
Signed-off-by: Lennart Jern <[email protected]>
Rename confusing variables. Mostly "hostname" -> "name", because it didn't have anything to do with the hostname. It is just the name of the VM we create, and that happens to also become the hostname unless changed elsewhere. Simplify LoadBMCConfig and vbmctl main. Signed-off-by: Lennart Jern <[email protected]>
Initialize the connection once and reuse, instead of constantly creating new connections. Signed-off-by: Lennart Jern <[email protected]>
|
Skipping CI for Draft Pull Request. |
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
metal3-io-bot
removed
the
do-not-merge/work-in-progress
|
/test metal3-ubuntu-e2e-integration-main |
|
@tuminoid: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal3-centos-e2e-integration-test-main |
|
/test metal3-ubuntu-e2e-integration-test-main |
What this PR does / why we need it:
This refactors and simplifies vbmctl by:
This all comes from trying to switch e2e to UEFI. It has grown too large so to avoid a monster PR, I'm now trying to push one piece at a time.
There is still a lot that could be done for vbmctl. In particular, reusing the same config struct for the tests and for creating the VMs is not ideal. We end up entangling the way we emulate bare metal with the actual test code, which should not care, nor know about it. It is also easy to get confused when some of the fields are ignored by either part of the system.