🌱 [WIP] Allow vbmctl to create VM with multiple network interfaces #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
mquhuy
force-pushed
the
mquhuy/vbmctl-multiple-networks
branch
3 times, most recently
from
a3de0e6 to
a5e5470
Compare
mquhuy
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
Rozzii
reviewed
Jan 24, 2025
mquhuy
force-pushed
the
mquhuy/vbmctl-multiple-networks
branch
from
72d4817 to
7b542ec
Compare
mquhuy
changed the title
mquhuy
force-pushed
the
mquhuy/vbmctl-multiple-networks
branch
5 times, most recently
from
827a1d2 to
8e11b03
Compare
vbmctl currently creates VM with 1 network interface. This is enough for BMO E2E, but to be able to have VMs that work for other purposes, having the flexibility to have multiple networks is required. Signed-off-by: Huy Mai <[email protected]>
mquhuy
force-pushed
the
mquhuy/vbmctl-multiple-networks
branch
from
8e11b03 to
67e088d
Compare
Signed-off-by: Huy Mai <[email protected]>
mquhuy
force-pushed
the
mquhuy/vbmctl-multiple-networks
branch
from
67e088d to
99413b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vbmctl currently creates VM with 1 network interface. This is enough for BMO E2E, but to be able to have VMs that work for other purposes, having the flexibility to have multiple networks is required.