🌱 E2E: Use UEFI #2204
Open
🌱 E2E: Use UEFI #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/S
lentzi90
commented
Jan 21, 2025
| @@ -143,7 +143,6 @@ mkdir -p "${IMAGE_DIR}" | |||
| ## Download disk images | |||
| wget --quiet -P "${IMAGE_DIR}/" https://artifactory.nordix.org/artifactory/metal3/images/iso/"${IMAGE_FILE}" | |||
| wget --quiet -P "${IMAGE_DIR}/" https://fastly-cdn.system-rescue.org/releases/11.00/systemrescue-11.00-amd64.iso | |||
| wget --quiet -P "${IMAGE_DIR}/" https://artifactory.nordix.org/artifactory/metal3/images/iso/minimal_linux_live-v2.iso | |||
There was a problem hiding this comment.
This is not used in the tests so there is no point downloading it.
Oh. I need to rethink this a bit then. |
Signed-off-by: Lennart Jern <[email protected]>
Rename confusing variables. Mostly "hostname" -> "name", because it didn't have anything to do with the hostname. It is just the name of the VM we create, and that happens to also become the hostname unless changed elsewhere. Simplify LoadBMCConfig and vbmctl main. Signed-off-by: Lennart Jern <[email protected]>
Initialize the connection once and reuse, instead of constantly creating new connections. Signed-off-by: Lennart Jern <[email protected]>
Switch e2e tests to UEFI instead of Legacy. Signed-off-by: Lennart Jern <[email protected]>
Signed-off-by: Lennart Jern <[email protected]>
lentzi90
force-pushed
the
lentzi90/e2e-uefi
branch
from
e6d9078 to
2eaffd7
Compare
metal3-io-bot
added
size/L
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Switch e2e tests to UEFI instead of Legacy.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #