-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 E2E: Revert temporary pinning of Ironic #2113
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lentzi90 rebase to see if the deep inspection disable is working and we can revert this. |
fbc8244
to
db1baec
Compare
New changes are detected. LGTM label has been removed. |
I'm not quite sure how to interpret this. Does it mean that IPA could not find the disk image after downloading it? 🤔 |
yeah or some permission issue |
The issue has been fixed so we can safely revert the workaround. Signed-off-by: Lennart Jern <[email protected]>
db1baec
to
ec01fe0
Compare
I have hijacked this PR as it seems we needed a rebase to pass the tests. |
What this PR does / why we need it:
The issue has been fixed so we can safely revert the workaround.
Revert of #2112
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/hold
until the issue is properly fixed.
Expecting the live-ISO test to fail here.