Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Revert temporary pinning of Ironic #2113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Dec 9, 2024

What this PR does / why we need it:

The issue has been fixed so we can safely revert the workaround.
Revert of #2112

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/hold
until the issue is properly fixed.
Expecting the live-ISO test to fail here.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lentzi90. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
@tuminoid
Copy link
Member

@lentzi90 rebase to see if the deep inspection disable is working and we can revert this.

@lentzi90 lentzi90 force-pushed the lentzi90/revert-temp-ironic-pin branch from fbc8244 to db1baec Compare December 17, 2024 09:33
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@metal3-io-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@lentzi90
Copy link
Member Author

    errorMessage: |-
      Image provisioning failed: Deploy step deploy.write_image failed on node 5597e2c0-74b5-41f5-a335-b79393d87a00. Unexpected error while running command.
      Command: /opt/ironic-python-agent/bin/python3 -m oslo_concurrency.prlimit --as=2147483648 -- ['env', 'LC_ALL=C', 'LANG=C', 'qemu-img', 'info', '/tmp/cirros-0.6.2-x86_64-disk.img', '--output=json']
      Exit code: 1
      Stdout: ''
      Stderr: "python3 -m oslo_concurrency.prlimit: failed to execute ['env', 'LC_ALL=C', 'LANG=C', 'qemu-img', 'info', '/tmp/cirros-0.6.2-x86_64-disk.img', '--output=json']: [Errno 2] No such file or directory\n"
    errorType: provisioning error

I'm not quite sure how to interpret this. Does it mean that IPA could not find the disk image after downloading it? 🤔
@Rozzii

@Rozzii
Copy link
Member

Rozzii commented Dec 18, 2024

    errorMessage: |-
      Image provisioning failed: Deploy step deploy.write_image failed on node 5597e2c0-74b5-41f5-a335-b79393d87a00. Unexpected error while running command.
      Command: /opt/ironic-python-agent/bin/python3 -m oslo_concurrency.prlimit --as=2147483648 -- ['env', 'LC_ALL=C', 'LANG=C', 'qemu-img', 'info', '/tmp/cirros-0.6.2-x86_64-disk.img', '--output=json']
      Exit code: 1
      Stdout: ''
      Stderr: "python3 -m oslo_concurrency.prlimit: failed to execute ['env', 'LC_ALL=C', 'LANG=C', 'qemu-img', 'info', '/tmp/cirros-0.6.2-x86_64-disk.img', '--output=json']: [Errno 2] No such file or directory\n"
    errorType: provisioning error

I'm not quite sure how to interpret this. Does it mean that IPA could not find the disk image after downloading it? 🤔 @Rozzii

yeah or some permission issue

The issue has been fixed so we can safely revert the workaround.

Signed-off-by: Lennart Jern <[email protected]>
@Rozzii Rozzii force-pushed the lentzi90/revert-temp-ironic-pin branch from db1baec to ec01fe0 Compare December 19, 2024 13:17
@Rozzii
Copy link
Member

Rozzii commented Dec 19, 2024

I have hijacked this PR as it seems we needed a rebase to pass the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants